[amp-list-load-more] documentation, demo, bugfix, and ui tweaks#19399
Merged
cathyxz merged 17 commits intoampproject:masterfrom Nov 28, 2018
Merged
[amp-list-load-more] documentation, demo, bugfix, and ui tweaks#19399cathyxz merged 17 commits intoampproject:masterfrom
cathyxz merged 17 commits intoampproject:masterfrom
Conversation
bc6d0ee to
1dabbf2
Compare
cathyxz
commented
Nov 21, 2018
cathyxz
commented
Nov 21, 2018
cvializ
reviewed
Nov 26, 2018
Contributor
cvializ
left a comment
There was a problem hiding this comment.
Nice! Some questions before LGTM.
aghassemi
reviewed
Nov 28, 2018
Contributor
Author
|
Merging master for the bundle size check issue. |
Contributor
CrystalOnScript
left a comment
There was a problem hiding this comment.
So sorry for the delayed review! Overall, looks really good! Just a it of confusion and a small nit.
| If `binding` attribute is not provided, default is `always`. | ||
|
|
||
| ## Experimental: Infinite Scroll (amp-list-load-more) | ||
| We've introduced an experiment called `amp-list-load-more` as an implementation for pagination and infinite scroll in amp-list. This is an experimental feature, and final APIs may change. |
Contributor
There was a problem hiding this comment.
nit: remove comma between "experimental feature, and final"
|
|
||
| ### Attributes | ||
| #### load-more (mandatory) | ||
| Adding this attribute will allow amp-list (with no value) to show a “load-more" button at the end of the amp-list. The value of this attribute can be set to “auto" to trigger automatic loading more elements three viewports down for an infinite scroll effect. |
Contributor
There was a problem hiding this comment.
Mind updating all mentions of amp-list are surrounded in ``` and tag marks?
| `<amp-list>` with the `load-more` attribute expects the following additional child elements: | ||
|
|
||
| #### load-more-button (mandatory) | ||
| An element containing the `load-more-button` attribute. Clicking on this button will trigger a fetch to load more elements from the url contained in the field of the data returned corresponding to the `load-more-bookmark` attribute. |
Contributor
There was a problem hiding this comment.
We call it an element and a button. Should the element be <button> or can it be any element used as a button? If there are only specific types of elements that can be used we should list them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #14060, #9423.
reloadCallback, to implement button to reload last link after 404-ing.