Conversation
|
Looks good, please squash commits. |
3320487 to
16ef72a
Compare
|
Did you see my note about adding For example, consider the URL https://cdn.ampproject.org/c/washingtonpost.com/amphtml/news/wonk/wp/2016/02/08/the-fairest-and-funniest-way-to-split-the-dinner-bill/, which is a Washington Post article served by the AMP Cache. With just a referrer-based tracking, you would attribute the traffic to cdn.ampproject.org. However, in this case, the appropriate attribution is to washingtonpost.com, which you can get via either of these variables: |
|
Hi @rudygalfi - Yes, but unfortunately, we can't process it for the moment. I need to talk about that with our teams. |
|
@BenDz There is one lint error (See travis). Please fix and this is good to go. |
| } | ||
| }, | ||
|
|
||
| 'atinternet': { |
There was a problem hiding this comment.
there seem to be two copies of the config. Can you remove one of them?
206482e to
2522627
Compare
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
Trailing space removal
2522627 to
4d5a5d0
Compare
|
@BenDz Wondering if you've had a chance to consider the proposed revision
|
|
@amphtml-team We just had a meeting, and we won't push |
|
@BenDz that sounds ok. Did you check the lint error that @cramforce
|
|
@amphtml-team This should be good in my last commit BenDz@4d5a5d0 |
|
@BenDz Thanks, see that. Can you rebase? It looks like there are conflicts to resolve. |
|
@BenDz And also squash your commits? https://github.com/ginatrapani/todo.txt-android/wiki/Squash-All-Commits-Related-to-a-Single-Issue-into-a-Single-Commit |
|
@rudygalfi Thanks! |
No description provided.