✨Added Preact to the Dev Dashboard using Rollup#18719
Closed
torch2424 wants to merge 2 commits intoampproject:masterfrom
Closed
✨Added Preact to the Dev Dashboard using Rollup#18719torch2424 wants to merge 2 commits intoampproject:masterfrom
torch2424 wants to merge 2 commits intoampproject:masterfrom
Conversation
|
This pull request introduces 1 alert when merging f55f2b1 into 3d4ae03 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
Contributor
Author
|
Closing in favor of: #18796 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: PR looks big from committing the package-lock, and initial build output, and seperating the original template.html into more appropriate files
This adds preact support to the dashboard, using Rollup and babel, and creating a small project within the project essentially.
Currently, this is built by placing the iife bundle into our template using mustacheJS, and then the server we have serving it, will place in the examples. I know it's kinda hack-y but the PR was already getting big, and I saw #18718 So I was like, lets just get this reviewed real quick haha!
So the original Proxy conversion and I guess "Top half" of the website is rendered using preact, the bottom half is still SSR'd
Example