Updates the extensions README to include added tags#1834
Closed
Meggin wants to merge 1 commit intoampproject:masterfrom
Closed
Updates the extensions README to include added tags#1834Meggin wants to merge 1 commit intoampproject:masterfrom
Meggin wants to merge 1 commit intoampproject:masterfrom
Conversation
| | [`amp-install-serviceworker`](amp-install-serviceworker/amp-install-serviceworker.md) | Installs a ServiceWorker. | | ||
| | [`amp-lightbox`](amp-lightbox/amp-lightbox.md) | Allows for a “lightbox” or similar experience. | | ||
| | [`amp-list`](amp-list/amp-list.md) | Dynamically downloads data and creates list items using a template. | | ||
| | [`amp-mustache`](amp-mustache/amp-mustache.md) | Allows rendering of [`Mustache.js`](https://github.com/janl/mustache.js/) templates. | |
Contributor
There was a problem hiding this comment.
Don't think Mustache.js needs to be formatted as code (...).
Contributor
|
One really tiny thing. LGTM |
Contributor
Author
|
Not only did this have merge conflicts, but I noticed more new components to add. So I went and did that in this pull request which has been merged: #2052. So closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New pull request that cherry picks updates to extensions table only.