add support for piano analytics#1652
Closed
nathangoulding wants to merge 1 commit intoampproject:masterfrom
Closed
add support for piano analytics#1652nathangoulding wants to merge 1 commit intoampproject:masterfrom
nathangoulding wants to merge 1 commit intoampproject:masterfrom
Conversation
Contributor
|
assigning to @avimehta for an initial review. |
Member
|
@nathangoulding Thank you!!! |
Contributor
|
Almost there. mostly lgtm. only one small comment. Sorry for the delay. Please rebase to HEAD after you address the one comment. cc @rudygalfi |
Contributor
|
FYI: I created a tracking intent to implement issue: #1769 |
Contributor
|
any updates on this? Please rebase and address the comment. We are almost there! |
Author
|
Just rebased and believe I've addressed the comments. Thanks! |
Contributor
|
FYI. New PR opened in #2075 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial support for Piano (http://piano.io) AI analytics.