Skip to content

♻️✨Clean up autoplay interaction mask creation + a11y#16177

Merged
alanorozco merged 4 commits intoampproject:masterfrom
alanorozco:role
Jun 20, 2018
Merged

♻️✨Clean up autoplay interaction mask creation + a11y#16177
alanorozco merged 4 commits intoampproject:masterfrom
alanorozco:role

Conversation

@alanorozco
Copy link
Copy Markdown
Member

@alanorozco alanorozco commented Jun 20, 2018

  1. Sets role=button for a11y.
  2. Uses common render functions for autoplay mask + icon.

Closes #12480

Copy link
Copy Markdown
Contributor

@cvializ cvializ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* @private
* @return {!Element}
*/
createAutoplayAnimation_() {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✂️✂️✂️nice ✂️✂️✂️

@alanorozco alanorozco merged commit b08f1f6 into ampproject:master Jun 20, 2018
@alanorozco alanorozco deleted the role branch June 20, 2018 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants