✨🏗 Add expectAsyncConsoleError, which enables tests to check for async errors#15621
Merged
rsimha merged 1 commit intoampproject:masterfrom May 26, 2018
rsimha:2018-05-25-AsyncErrors
Merged
✨🏗 Add expectAsyncConsoleError, which enables tests to check for async errors#15621rsimha merged 1 commit intoampproject:masterfrom rsimha:2018-05-25-AsyncErrors
expectAsyncConsoleError, which enables tests to check for async errors#15621rsimha merged 1 commit intoampproject:masterfrom
rsimha:2018-05-25-AsyncErrors
Conversation
This was referenced May 26, 2018
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
allowConsoleErrorconstruct lets you capture synchronous calls toconsole.errorin a test, and indicate that they are expected and that the test shouldn't fail. However, when test code results in asynchronous errors, there's no good way to useallowConsoleErroras written today.This PR does the following:
expectAsyncConsoleError, which lets you specify that a given asynchronousconsole.erroris expected at some point during the test.expectAsyncConsoleErrorannotation to all tests inextensions/amp-analytics/0.1/test/test-amp-analytics.jsthat were resulting in async errorsFixes #15609
Required for #14406