Wait for page load before Percy snapshot#10078
Merged
rsimha merged 1 commit intoampproject:masterfrom Jun 21, 2017
rsimha:2017-06-21-WaitForLoad
Merged
Wait for page load before Percy snapshot#10078rsimha merged 1 commit intoampproject:masterfrom rsimha:2017-06-21-WaitForLoad
rsimha merged 1 commit intoampproject:masterfrom
rsimha:2017-06-21-WaitForLoad
Conversation
cramforce
approved these changes
Jun 21, 2017
Member
cramforce
left a comment
There was a problem hiding this comment.
This might not catch every last case, but it is quite elegant :)
Contributor
Author
|
@cramforce, agreed that this may not catch every case. See my note above re: testing this with an element that does exist on the page, and seeing that |
Contributor
Author
|
100+ green runs in a row. Consider this issue fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Speculative fix that I believe should work as an implicit wait for the page to fully load.
Tested this by searching for
.i-amphtml-layout, which is a CSS element that does exist on the page, and the call tohas_no_csswaited for a couple of seconds before returningfalse.Fixes #10022