🚀 [Story localization] Removed localization strings from js#38280
Merged
mszylkowski merged 6 commits intoampproject:mainfrom Jun 9, 2022
Merged
🚀 [Story localization] Removed localization strings from js#38280mszylkowski merged 6 commits intoampproject:mainfrom
mszylkowski merged 6 commits intoampproject:mainfrom
Conversation
|
This pull request fixes 1 alert when merging 8709337 into 9cfa89f - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging 8382175 into b7954b6 - view on LGTM.com fixed alerts:
|
|
Hey @gmajoulet! These files were changed: Hey @newmuis! These files were changed: |
gmajoulet
approved these changes
Jun 8, 2022
Contributor
|
-9.3kB
|
|
This pull request fixes 1 alert when merging 510b7c7 into b7954b6 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging 95f6f2e into 32e83d3 - view on LGTM.com fixed alerts:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove all localization strings to rely on the JS.
This removes the experiment flag because opting-out of this experiment cannot be done (the localizations strings are removed completely from the bundle).