🐛 [Story attachment] Fix cta-image=none showing link icon#38109
🐛 [Story attachment] Fix cta-image=none showing link icon#38109processprocess merged 24 commits intoampproject:mainfrom
Conversation
…of github.com:ampproject/amphtml
|
Hey @gmajoulet, @newmuis! These files were changed: |
processprocess
left a comment
There was a problem hiding this comment.
Thank you for catching, fixing and adding the unit test.
|
Can you link the bug report, with real world Story examples? Is amphtml/extensions/amp-story/validator-amp-story.protoascii Lines 908 to 914 in c813c13 |
The bug was reported on Slack (so no issue I think), and could be tested with the local story The validation seems to confirm the attribute set to "none" is valid, though I don't know exactly where this validation rule comes from. https://validator.ampproject.org/ seems to agree that it's valid AMP. |
The cta-image=none on outlinks should hide the link icon, but due to a regression on #36706 the link icon was being shown. This PR hides the icon if cta-image=none for the open-page-attachment UI.
Added tests to verify this behavior so it's not broken in the future.
It now works (vis diff for no-image CTA was wrong before):
