Skip to content

✨ [Story Preview] Allow all story pages and grid layers to be rendered in preview mode#38030

Merged
coreymasanto merged 9 commits intoampproject:mainfrom
coreymasanto:previewAllowedTrue
Apr 18, 2022
Merged

✨ [Story Preview] Allow all story pages and grid layers to be rendered in preview mode#38030
coreymasanto merged 9 commits intoampproject:mainfrom
coreymasanto:previewAllowedTrue

Conversation

@coreymasanto
Copy link
Copy Markdown
Contributor

@coreymasanto coreymasanto commented Apr 6, 2022

previewAllowed() was defaulting to prerenderAllowed() behavior for story pages and grid layers, but this behavior only allows the first story page and its grid layers to be rendered. In preview mode, all pages and grid layers must be rendered so that they can be seen in the SERP while the story auto-advances.

@coreymasanto coreymasanto marked this pull request as ready for review April 7, 2022 16:13
@coreymasanto coreymasanto requested a review from gmajoulet April 7, 2022 16:13
@amp-owners-bot
Copy link
Copy Markdown

amp-owners-bot bot commented Apr 7, 2022

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story/1.0/amp-story-grid-layer.js
extensions/amp-story/1.0/amp-story-page.js
extensions/amp-story/1.0/test/test-amp-story-page.js

gmajoulet
gmajoulet reviewed Apr 8, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@gmajoulet gmajoulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you host demos for these PRs so I can help you with manual testing as well? Code LGTM : ))

@coreymasanto coreymasanto enabled auto-merge (squash) April 18, 2022 21:23
@coreymasanto coreymasanto merged commit 68a618d into ampproject:main Apr 18, 2022
@ampprojectbot
Copy link
Copy Markdown
Member

ampprojectbot commented Apr 18, 2022

Warning: disparity between this PR Percy build and its main build

The Percy build for this PR was approved (either manually by a member of the AMP team, or automatically if there were no visual diffs). However, during a continuous integration step we generated another Percy build using the commit on the main branch that this PR was merged into, and there appears to be a mismatch between the two.

This is possibly an indication of an issue with this pull request, but could also be the result of flakiness. Please inspect the two builds < This PR's Percy build / main commit's Percy build > and determine further action:

  • If the disparity appears to be caused by this PR, please create an bug report or send out a new PR to fix
  • If the disparity appears to be a flake, please @-mention ampproject/wg-approvers in a comment
  • If there is no disparity and this comment was created by mistake, please @-mention ampproject/wg-infra
  • If unsure, @-mention ampproject/wg-approvers

@jshamble jshamble mentioned this pull request May 20, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmajoulet gmajoulet gmajoulet approved these changes

Assignees

No one assigned

Labels

PR use: In Beta / Experimental PR use: In Stable

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@coreymasanto @ampprojectbot @gmajoulet