♻️🚀 amp-story: Use Services.urlForDoc instead of util functions#38026
Merged
alanorozco merged 11 commits intoampproject:mainfrom Apr 6, 2022
Merged
♻️🚀 amp-story: Use Services.urlForDoc instead of util functions#38026alanorozco merged 11 commits intoampproject:mainfrom
amp-story: Use Services.urlForDoc instead of util functions#38026alanorozco merged 11 commits intoampproject:mainfrom
Conversation
|
Hey @gmajoulet! These files were changed: Hey @mszylkowski! These files were changed: Hey @newmuis! These files were changed: |
alanorozco
commented
Apr 6, 2022
mszylkowski
approved these changes
Apr 6, 2022
gmajoulet
approved these changes
Apr 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the service is provided by the runtime, using it prevents us from including duplicate util implementations in the
amp-storybundle.This reduces the size of
amp-story-1.0by0.41kBin ESM and0.82kB(!!!) in nomodule.