Skip to content

🚀 [Story localization] Asnyc all remaining usages of localization service [part 2]#37969

Merged
mszylkowski merged 35 commits intoampproject:mainfrom
mszylkowski:localizeAll
Mar 29, 2022
Merged

🚀 [Story localization] Asnyc all remaining usages of localization service [part 2]#37969
mszylkowski merged 35 commits intoampproject:mainfrom
mszylkowski:localizeAll

Conversation

@mszylkowski
Copy link
Copy Markdown
Contributor

@mszylkowski mszylkowski commented Mar 28, 2022

Follows #37947

I2I: #37344

@mszylkowski mszylkowski marked this pull request as ready for review March 28, 2022 19:16
@amp-owners-bot amp-owners-bot bot requested review from dvoytenko and gmajoulet March 28, 2022 19:16
@amp-owners-bot
Copy link
Copy Markdown

Hey @gmajoulet! These files were changed:

extensions/amp-story-page-attachment/0.1/amp-story-draggable-drawer.js
extensions/amp-story-page-attachment/0.1/amp-story-form.js
extensions/amp-story-page-attachment/0.1/amp-story-open-page-attachment.js
extensions/amp-story-page-attachment/0.1/amp-story-page-attachment.js
extensions/amp-story-page-attachment/0.1/test/test-amp-story-open-page-attachment.js
extensions/amp-story-page-attachment/0.1/test/test-amp-story-page-attachment.js
extensions/amp-story-share-menu/0.1/amp-story-share-menu.js
extensions/amp-story-shopping/0.1/amp-story-shopping-attachment.js
extensions/amp-story/1.0/pagination-buttons.js
extensions/amp-story/1.0/test/test-amp-story.js

Hey @newmuis! These files were changed:

extensions/amp-story-page-attachment/0.1/amp-story-draggable-drawer.js
extensions/amp-story-page-attachment/0.1/amp-story-form.js
extensions/amp-story-page-attachment/0.1/amp-story-open-page-attachment.js
extensions/amp-story-page-attachment/0.1/amp-story-page-attachment.js
extensions/amp-story-page-attachment/0.1/test/test-amp-story-open-page-attachment.js
extensions/amp-story-page-attachment/0.1/test/test-amp-story-page-attachment.js
extensions/amp-story-share-menu/0.1/amp-story-share-menu.js
extensions/amp-story/1.0/pagination-buttons.js
extensions/amp-story/1.0/test/test-amp-story.js

@mszylkowski mszylkowski removed the request for review from dvoytenko March 28, 2022 19:16
Co-authored-by: Gabriel Majoulet <gmajoulet@google.com>
@mszylkowski mszylkowski requested a review from erwinmombay March 29, 2022 13:44
@mszylkowski
Copy link
Copy Markdown
Contributor Author

@erwinmombay for OWNERS on localization/index.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants