🚀 [Story performance] Remove FOUT on font loading of amp-story-education#37928
Merged
mszylkowski merged 19 commits intoampproject:mainfrom Mar 22, 2022
Merged
🚀 [Story performance] Remove FOUT on font loading of amp-story-education#37928mszylkowski merged 19 commits intoampproject:mainfrom
mszylkowski merged 19 commits intoampproject:mainfrom
Conversation
|
Hey @gmajoulet! These files were changed: |
gmajoulet
reviewed
Mar 21, 2022
gmajoulet
approved these changes
Mar 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Amp-story-education installs 40kB of Open Sans fonts (3 weights) that load after amp-story-education so the critical path to install the fonts takes a significant time. Currently we don't specify any loading strategy which makes a FOUT (flash of unstyled text) that is registered as a CLS.
We can use https://www.industrialempathy.com/perfect-ish-font-fallback/?font=Open%20Sans to remove the FOUT by setting the fallback height of Arial to match the height of the font.