Skip to content

✨ [amp story shopping] Change productBrand to productVendor and make it optional#37897

Merged
processprocess merged 2 commits intoampproject:mainfrom
processprocess:vendor
Mar 18, 2022
Merged

✨ [amp story shopping] Change productBrand to productVendor and make it optional#37897
processprocess merged 2 commits intoampproject:mainfrom
processprocess:vendor

Conversation

@processprocess
Copy link
Copy Markdown
Contributor

@processprocess processprocess commented Mar 17, 2022 •
edited
Loading

Vendor is more general wording that can include terminology for brand or shop.
This is also more in-line with other shopping API naming conventions.

  • Updates the key name from productBrand to productVendor in product data.
  • Updates all visual test html documents.
  • Makes the value optional in the templates.
  • Updates CSS to align PLP cards.

Screen Shot 2022-03-17 at 3 31 10 PM

I2S and I2I documents will need to be updated with this change.

@processprocess processprocess self-assigned this Mar 17, 2022
@processprocess processprocess requested a review from jshamble March 17, 2022 21:00
@processprocess processprocess marked this pull request as ready for review March 17, 2022 21:00
@amp-owners-bot
Copy link
Copy Markdown

amp-owners-bot bot commented Mar 17, 2022

Hey @gmajoulet! These files were changed:

extensions/amp-story-shopping/0.1/amp-story-shopping-attachment.css
extensions/amp-story-shopping/0.1/amp-story-shopping-attachment.js
extensions/amp-story-shopping/0.1/test/test-amp-story-shopping-attachment.js
extensions/amp-story-shopping/0.1/test/test-amp-story-shopping-config.js
extensions/amp-story/1.0/amp-story-store-service.js

Hey @newmuis! These files were changed:

extensions/amp-story/1.0/amp-story-store-service.js

@processprocess processprocess merged commit 645899f into ampproject:main Mar 18, 2022
@processprocess processprocess deleted the vendor branch March 18, 2022 13:11
@processprocess
Copy link
Copy Markdown
Contributor Author

processprocess commented Mar 18, 2022

@jshamble Please be sure to update this in the validation PR #37474 :)
productBrand => productVendor.

This was referenced Mar 25, 2022
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmajoulet gmajoulet gmajoulet approved these changes

@jshamble jshamble Awaiting requested review from jshamble

Assignees

@processprocess processprocess

Labels

P1: High Priority PR use: In Beta / Experimental PR use: In LTS PR use: In Stable WG: stories

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@processprocess @gmajoulet @ampprojectbot