✨ [Story localization] Use inlined JSONs for localization bundles#37836
Merged
mszylkowski merged 25 commits intoampproject:mainfrom Mar 10, 2022
Merged
✨ [Story localization] Use inlined JSONs for localization bundles#37836mszylkowski merged 25 commits intoampproject:mainfrom
mszylkowski merged 25 commits intoampproject:mainfrom
Conversation
|
Hey @gmajoulet, @newmuis! These files were changed: |
gmajoulet
reviewed
Mar 8, 2022
|
|
||
| // If there are inline strings, register as current document language. | ||
| const inlineStrings = this.win.document.querySelector( | ||
| 'script[amp-strings="amp-story"]' |
Contributor
There was a problem hiding this comment.
Is it still time to use a more specific word than just string? Would be cool to add localization or i18n or anything in the mix
Contributor
Author
There was a problem hiding this comment.
We can change it since the transformer wasn't merged AFAIK. Sth like what's below looks good to you?
<script amp-localization="amp-story" i-amphtml-version="123456"></script>to follow closely
<style amp-extension="amp-story" i-amphtml-version="123456"></style>cc @erwinmombay for the transformer change.
Co-authored-by: Gabriel Majoulet <gmajoulet@google.com>
…nto stringjson_inlined
gmajoulet
reviewed
Mar 10, 2022
Co-authored-by: Gabriel Majoulet <gmajoulet@google.com>
gmajoulet
approved these changes
Mar 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the localization strings are inlined in the document and have the correct version, then we will want to use them.
This PR allows stories on 60+ languages to be translated correctly from the AMP cache once the translations are inlined.