🐛 [Story attachment] Opening outlink error for closeButton being null#37833
Merged
mszylkowski merged 19 commits intoampproject:mainfrom Mar 8, 2022
Merged
🐛 [Story attachment] Opening outlink error for closeButton being null#37833mszylkowski merged 19 commits intoampproject:mainfrom
mszylkowski merged 19 commits intoampproject:mainfrom
Conversation
|
Hey @gmajoulet, @newmuis! These files were changed: |
Contributor
Author
|
For sure, I think in general the feature is undertested but any unit test that checks this functionality should have picked it up. I'll add a generic test for the outlink component that would have caught this error (and potentially many other ones like it). |
calebcordry
reviewed
Mar 8, 2022
extensions/amp-story-page-attachment/0.1/test/test-amp-story-page-attachment.js
Outdated
Show resolved
Hide resolved
Contributor
|
Thank you for fixing this & writing a test for it ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ampproject/error-reporting#147
Outlinks when opened don't have a
closeButtonthat they can change thetabindexso it was throwing an error. By checking if there's such button we can prevent the error and run the last lines of theopen()method properly.