♻️ [amp story shopping] Rename tag-id to product-id#37527
Merged
processprocess merged 2 commits intoampproject:mainfrom Jan 31, 2022
Merged
♻️ [amp story shopping] Rename tag-id to product-id#37527processprocess merged 2 commits intoampproject:mainfrom
processprocess merged 2 commits intoampproject:mainfrom
Conversation
|
Hey @gmajoulet! These files were changed: Hey @newmuis! These files were changed: |
newmuis
approved these changes
Jan 31, 2022
Contributor
|
Can you please update the I2I as well? |
Contributor
Author
Was doing that right now actually :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes semantics be more symmetric by using
data-product-idinstead ofdata-tag-id.This helps put emphasis on the product instead of the tag since the product is what's being identified, and not the tag itself.