🐛 [amp story shopping] Do not render shopping CTA if no shopping tags are on the page#37503
Merged
processprocess merged 10 commits intoampproject:mainfrom Feb 2, 2022
Merged
🐛 [amp story shopping] Do not render shopping CTA if no shopping tags are on the page#37503processprocess merged 10 commits intoampproject:mainfrom
processprocess merged 10 commits intoampproject:mainfrom
Conversation
|
Hey @gmajoulet! These files were changed: Hey @newmuis! These files were changed: |
mszylkowski
reviewed
Jan 27, 2022
Contributor
There was a problem hiding this comment.
Nit:
If there are no shopping tags, the attachment extension will still be fetched right? How often would this happen?
We could prevent that by removing the tag from the querySelector on amp-story-page and on shopping-attachment install the extension.
530d7c1 to
9ec5aa3
Compare
gmajoulet
reviewed
Jan 28, 2022
mszylkowski
approved these changes
Feb 1, 2022
Contributor
mszylkowski
left a comment
There was a problem hiding this comment.
Could be useful to add tests to check whether the attachment is built or not, code is 👍
gmajoulet
approved these changes
Feb 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building the attachment was refactored as part of #37278 to be a separate component and introduced a regression which was not caught since Percy diffs were broken at the time of submitting the PR.
This PR removes dead code that previously prevented the CTA from being built if no shopping-tags are on the page (originally done in #37004) and puts the functionality in amp-story-shopping-attachment.
It also renames
renderOpenAttachmentUI_toinstallPageAttachmentExtension_to better describe functionality.