🐛 [amp story shopping] shopping CTA label fix#37502
Merged
processprocess merged 1 commit intoampproject:mainfrom Jan 27, 2022
Merged
🐛 [amp story shopping] shopping CTA label fix#37502processprocess merged 1 commit intoampproject:mainfrom
processprocess merged 1 commit intoampproject:mainfrom
Conversation
|
Hey @gmajoulet, @newmuis, @mszylkowski! These files were changed: |
mszylkowski
approved these changes
Jan 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building the attachment was refactored as part of #37278 to be a separate component and introduced a regression which was not caught since Percy diffs were broken at the time of submitting the PR.
this.elementis now a reference toamp-story-page-outlinkoramp-story-page-attachmentand neveramp-story-shopping-attachment.This PR checks the parent element to see if it's an
amp-story-shopping-attachmentto create the appropriate label.