Skip to content

📖 [Story analytics] Use amp-story-share-menu for share analytics#37475

Merged
gmajoulet merged 11 commits intoampproject:mainfrom
mszylkowski:analyticsShareFix
Jan 25, 2022
Merged

📖 [Story analytics] Use amp-story-share-menu for share analytics#37475
gmajoulet merged 11 commits intoampproject:mainfrom
mszylkowski:analyticsShareFix

Conversation

@mszylkowski
Copy link
Copy Markdown
Contributor

@mszylkowski mszylkowski commented Jan 25, 2022 •
edited
Loading

The sharing trigger was accidentally changed from amp-story-share-menu to amp-story-share, reverting.

Adding example configuration triggers for share menu opening, on share.html and analytics.html

Closes #37446

@mszylkowski mszylkowski self-assigned this Jan 25, 2022
@mszylkowski mszylkowski requested a review from gmajoulet January 25, 2022 20:45
@mszylkowski
Copy link
Copy Markdown
Contributor Author

mszylkowski commented Jan 25, 2022

cc @cpauwels

@mszylkowski mszylkowski changed the title 📖 [Story documentation] Add example of share analytics config to demos 📖 [Story documentation] Use amp-story-share-menu for share analytics Jan 25, 2022
@amp-owners-bot
Copy link
Copy Markdown

amp-owners-bot bot commented Jan 25, 2022

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story/1.0/amp-story-share.js

@mszylkowski mszylkowski mentioned this pull request Jan 25, 2022
Closed
@mszylkowski mszylkowski changed the title 📖 [Story documentation] Use amp-story-share-menu for share analytics 📖 [Story analytics] Use amp-story-share-menu for share analytics Jan 25, 2022
@gmajoulet gmajoulet merged commit 1bda18d into ampproject:main Jan 25, 2022
@mszylkowski mszylkowski mentioned this pull request Jan 25, 2022
Closed
ampprojectbot pushed a commit that referenced this pull request Jan 26, 2022
@mszylkowski @ampprojectbot
📖 [Story analytics] Use amp-story-share-menu for share analytics (#…
4108b67 
…37475)

* Added tasts

* Undo

* Adding share examples for analytics

* Using share menu for analytics

(cherry picked from commit 1bda18d)
ampprojectbot pushed a commit that referenced this pull request Jan 26, 2022
@mszylkowski @ampprojectbot
📖 [Story analytics] Use amp-story-share-menu for share analytics (#…
947e3d0 
…37475)

* Added tasts

* Undo

* Adding share examples for analytics

* Using share menu for analytics

(cherry picked from commit 1bda18d)
ampprojectbot pushed a commit that referenced this pull request Jan 26, 2022
@mszylkowski @ampprojectbot
📖 [Story analytics] Use amp-story-share-menu for share analytics (#…
1b3401e 
…37475)

* Added tasts

* Undo

* Adding share examples for analytics

* Using share menu for analytics

(cherry picked from commit 1bda18d)
ampprojectbot pushed a commit that referenced this pull request Jan 26, 2022
@mszylkowski @ampprojectbot
📖 [Story analytics] Use amp-story-share-menu for share analytics (#…
dd024da 
…37475)

* Added tasts

* Undo

* Adding share examples for analytics

* Using share menu for analytics

(cherry picked from commit 1bda18d)
rileyajones pushed a commit to rileyajones/amphtml that referenced this pull request Jan 26, 2022
@mszylkowski @rileyajones
📖 [Story analytics] Use amp-story-share-menu for share analytics (a…
6b4a9ff 
…mpproject#37475)

* Added tasts

* Undo

* Adding share examples for analytics

* Using share menu for analytics
@mszylkowski mszylkowski mentioned this pull request Jan 31, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmajoulet gmajoulet gmajoulet approved these changes

Assignees

@mszylkowski mszylkowski

Labels

PR use: In Beta / Experimental PR use: In Stable

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[amp-story] Unmute and share events not firing anymore

3 participants

@mszylkowski @gmajoulet @ampprojectbot