🐛 [amp story] Change toggleAttribute to set/removeAttribute#37420
Merged
processprocess merged 6 commits intoampproject:mainfrom Jan 20, 2022
Merged
🐛 [amp story] Change toggleAttribute to set/removeAttribute#37420processprocess merged 6 commits intoampproject:mainfrom
processprocess merged 6 commits intoampproject:mainfrom
Conversation
|
Hey @gmajoulet! These files were changed: Hey @mszylkowski! These files were changed: Hey @newmuis! These files were changed: |
jridgewell
reviewed
Jan 19, 2022
extensions/amp-story-page-attachment/0.1/amp-story-draggable-drawer.js
Outdated
Show resolved
Hide resolved
processprocess
commented
Jan 19, 2022
| '\\.pageXOffset(?!_)': bannedTermsHelpString, | ||
| '\\.pageYOffset(?!_)': bannedTermsHelpString, | ||
| '\\.innerWidth(?!_)': bannedTermsHelpString, | ||
| '\\.toggleAttribute(?!_)': 'please use `toggleAttribute()` from core/dom', |
Contributor
Author
There was a problem hiding this comment.
@jridgewell I feel like we should add this to forbidden terms to prevent future errors. WDYT?
gmajoulet
approved these changes
Jan 19, 2022
jridgewell
approved these changes
Jan 20, 2022
mszylkowski
approved these changes
Jan 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
toggleAttribute is not widely supported so it fails on multiple platforms.
This PR uses the toggleAttribute utility function instead.
Fixes #120, #93