Skip to content

🚀 [Story performance] Remove logging and development UI from the amp-story bundle#37279

Merged
mszylkowski merged 8 commits intoampproject:mainfrom
mszylkowski:removeLogging
Jan 4, 2022
Merged

🚀 [Story performance] Remove logging and development UI from the amp-story bundle#37279
mszylkowski merged 8 commits intoampproject:mainfrom
mszylkowski:removeLogging

Conversation

@mszylkowski
Copy link
Copy Markdown
Contributor

@mszylkowski mszylkowski commented Dec 28, 2021

We don't need the development UI as it's not being used (this is not the devtools).

dist/v0/amp-story-0.1.mjs: Δ -0.96KB
dist/v0/amp-story-1.0.mjs: Δ -0.96KB
dist/v0/amp-story-0.1.js: Δ -1.69KB
dist/v0/amp-story-1.0.js: Δ -1.69KB

@mszylkowski mszylkowski marked this pull request as ready for review January 4, 2022 16:28
@amp-owners-bot
Copy link
Copy Markdown

amp-owners-bot bot commented Jan 4, 2022

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story/1.0/amp-story-page.js
extensions/amp-story/1.0/amp-story-system-layer.js
extensions/amp-story/1.0/amp-story.css
extensions/amp-story/1.0/amp-story.js
extensions/amp-story/1.0/development-ui.js
extensions/amp-story/1.0/events.js
extensions/amp-story/1.0/logging.js

@mszylkowski mszylkowski self-assigned this Jan 4, 2022
Copy link
Copy Markdown
Contributor

@processprocess processprocess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants