Skip to content

🚀 [Story performance] Remove unused strings from localization bundles#37229

Merged
mszylkowski merged 3 commits intoampproject:mainfrom
mszylkowski:removeUnusedStrings
Dec 16, 2021
Merged

🚀 [Story performance] Remove unused strings from localization bundles#37229
mszylkowski merged 3 commits intoampproject:mainfrom
mszylkowski:removeUnusedStrings

Conversation

@mszylkowski
Copy link
Copy Markdown
Contributor

@mszylkowski mszylkowski commented Dec 15, 2021

We can remove 5 strings from all localization bundles and deprecate 11 strings from the strings.js map.

Closes #37197

dist/v0/amp-story-0.1.mjs: Δ -1.20KB
dist/v0/amp-story-1.0.mjs: Δ -1.20KB
dist/v0/amp-story-0.1.js: Δ -1.37KB
dist/v0/amp-story-1.0.js: Δ -1.37KB

Also will remove strings from system layer redesign on: #37218

@amp-owners-bot
Copy link
Copy Markdown

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story/1.0/_locales/af.json
extensions/amp-story/1.0/_locales/am.json
extensions/amp-story/1.0/_locales/ar.json
extensions/amp-story/1.0/_locales/bg.json
extensions/amp-story/1.0/_locales/bn.json
extensions/amp-story/1.0/_locales/bs.json
extensions/amp-story/1.0/_locales/ca.json
extensions/amp-story/1.0/_locales/cs.json
extensions/amp-story/1.0/_locales/da.json
extensions/amp-story/1.0/_locales/de.json
extensions/amp-story/1.0/_locales/el.json
extensions/amp-story/1.0/_locales/en-GB.json
+60 more

@mszylkowski mszylkowski self-assigned this Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Story performance] Remove system sharing localization strings as it shouldn't be used

3 participants