Skip to content

♻️ [Story performance] Extract performance service into variable#37137

Merged
mszylkowski merged 9 commits intoampproject:mainfrom
mszylkowski:disableAnimationsTransformed
Dec 7, 2021
Merged

♻️ [Story performance] Extract performance service into variable#37137
mszylkowski merged 9 commits intoampproject:mainfrom
mszylkowski:disableAnimationsTransformed

Conversation

@mszylkowski
Copy link
Copy Markdown
Contributor

Performance service is fetched 4 times in a row. Extract into a variable and use just once

@mszylkowski mszylkowski self-assigned this Dec 7, 2021
@mszylkowski mszylkowski changed the title ♻️ [Story performance] Extract performance service ♻️ [Story performance] Extract performance service into variable Dec 7, 2021
@mszylkowski mszylkowski marked this pull request as ready for review December 7, 2021 20:35
@amp-owners-bot
Copy link
Copy Markdown

amp-owners-bot bot commented Dec 7, 2021

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story/1.0/amp-story.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants