🚀 [Story performance] Use dvh if available, instead of vh#37003
Merged
mszylkowski merged 5 commits intoampproject:mainfrom Nov 24, 2021
Merged
🚀 [Story performance] Use dvh if available, instead of vh#37003mszylkowski merged 5 commits intoampproject:mainfrom
mszylkowski merged 5 commits intoampproject:mainfrom
Conversation
|
Hey @gmajoulet, @newmuis! These files were changed: |
gmajoulet
approved these changes
Nov 18, 2021
jridgewell
requested changes
Nov 18, 2021
jridgewell
approved these changes
Nov 19, 2021
|
|
||
| amp-story[standalone]:-webkit-full-screen { | ||
| height: var(--story-100dvh) !important; | ||
| height: 100vh !important; |
Contributor
There was a problem hiding this comment.
Why isn't this using var(--story-100dvh)?
Contributor
Author
There was a problem hiding this comment.
Full screen pages don't have any issues with vh since the browser appbar is not showing, it should be always the same 1dvh = 1vh.
erwinmombay
approved these changes
Nov 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to introduce a CSS variable that accurately reflects the viewport height,
--story-dvh, that will allow us to inject a script inlined into the document to set the variable when the document loads, so on mobile browsers the pages won't have any CLS