📖 [Documentation] Added amp-video documentation that cache is not compatible with crossorigin#36772
Closed
mszylkowski wants to merge 2 commits intoampproject:mainfrom
Closed
📖 [Documentation] Added amp-video documentation that cache is not compatible with crossorigin#36772mszylkowski wants to merge 2 commits intoampproject:mainfrom
mszylkowski wants to merge 2 commits intoampproject:mainfrom
Conversation
Gregable
approved these changes
Nov 4, 2021
Contributor
Author
|
This will soon change so I'm closing it (we will be able to use |
Contributor
|
Can you revert this now that the issue is fixed? |
Contributor
Author
|
This was closed not merged, I closed it when we found out there was a fix for it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make sure people don't add the
crossoriginattribute when using the video cache.