Conversation
|
Hey @gmajoulet, @newmuis! These files were changed: |
kristoferbaxter
left a comment
There was a problem hiding this comment.
LGTM, but a test would be a good idea.
|
Given how this behavior relies on certain browsers' |
(cherry picked from commit 4b43359)
(cherry picked from commit 4b43359)
| this.cssVariablesStyleEl_.setAttribute('type', 'text/css'); | ||
| doc.head.appendChild(this.cssVariablesStyleEl_); | ||
| } | ||
| this.cssVariablesStyleEl_.textContent = `:root {--story-page-vh: ${px( |
There was a problem hiding this comment.
Nit: Why isn't this just an inline style on the <html> element?
There was a problem hiding this comment.
Specifically for this PR it's because it used to be like that, so I reverted that back.
In general, I think inlining the style would have made more sense (+ you don't have to keep track of this extra element).
(cherry picked from commit 4b43359)
Fixes #36711
Reverts removing the JS units calculation from #36033
Before / After (URLs match the original story and the demo story with change)
Also tested, and the styles for the desktop one-panel are not affected by the bug, and are also not affected by this fix (those styles are overriden). Also, the desktop one-panel is not shown on mobile UIs.