🐛 [amp-story-page-outlink] Force page outlinks to use target='_top' in order to prevent navigation from breaking on Safari#36428
Merged
coreymasanto merged 5 commits intoampproject:mainfrom Oct 21, 2021
Conversation
…m breaking on Safari
gmajoulet
approved these changes
Oct 20, 2021
|
Hey @gmajoulet, @newmuis! These files were changed: |
gmajoulet
approved these changes
Oct 20, 2021
Contributor
|
If you have time to add a unit test that'd be cool :)) |
…nk tests, along with a test verifying that outlink anchor elements always have a value of '_top'
Contributor
Author
Added a new test file! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The target must be '_top' for page outlinks, which will result in the link opening in the current tab. Opening links in a new tab requires a trusted event, and Safari does not consider swiping up to be trusted.
Before this PR, swiping up an
amp-story-page-outlinkwithtarget='_blank'on iOS Safari would result in a failed navigation and a broken story page. After this PR, anyamp-story-page-outlinkwill successfully open in the same tab as its story.