Skip to content

🚮 [amp story 360] Remove unnecessary .then statement#36409

Merged
processprocess merged 2 commits intoampproject:mainfrom
processprocess:remove-return
Oct 20, 2021
Merged

🚮 [amp story 360] Remove unnecessary .then statement#36409
processprocess merged 2 commits intoampproject:mainfrom
processprocess:remove-return

Conversation

@processprocess
Copy link
Copy Markdown
Contributor

The promise.all resolves when the services's promises resolve.
There is no need for the additional .then.

@amp-owners-bot
Copy link
Copy Markdown

Hey @gmajoulet, @t0mg! These files were changed:

extensions/amp-story-360/0.1/amp-story-360.js

Copy link
Copy Markdown
Contributor

@mszylkowski mszylkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants