Skip to content

🐛 [Story loading] Send storyContentLoaded during prerendering#36307

Merged
mszylkowski merged 17 commits intoampproject:mainfrom
mszylkowski:initializepages_loadevent
Oct 14, 2021
Merged

🐛 [Story loading] Send storyContentLoaded during prerendering#36307
mszylkowski merged 17 commits intoampproject:mainfrom
mszylkowski:initializepages_loadevent

Conversation

@mszylkowski
Copy link
Copy Markdown
Contributor

@mszylkowski mszylkowski commented Oct 8, 2021 •
edited
Loading

Closes #36288
Closes #36571

Should call markStoryAsLoaded on prerender when the first page contains an image or a video with cached source.

@mszylkowski mszylkowski requested a review from gmajoulet October 8, 2021 19:16
@mszylkowski mszylkowski self-assigned this Oct 8, 2021
mszylkowski
mszylkowski commented Oct 11, 2021
View reviewed changes
@mszylkowski mszylkowski marked this pull request as ready for review October 11, 2021 18:10
@amp-owners-bot
Copy link
Copy Markdown

amp-owners-bot bot commented Oct 11, 2021 •
edited
Loading

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story/1.0/amp-story-page.js
extensions/amp-story/1.0/amp-story.js
extensions/amp-story/1.0/test/test-amp-story.js

gmajoulet
gmajoulet approved these changes Oct 11, 2021
View reviewed changes
@mszylkowski mszylkowski enabled auto-merge (squash) October 11, 2021 20:19
@mszylkowski mszylkowski disabled auto-merge October 11, 2021 20:26
@mszylkowski mszylkowski merged commit 73201d9 into ampproject:main Oct 14, 2021
@mszylkowski mszylkowski deleted the initializepages_loadevent branch October 14, 2021 20:10
@processprocess processprocess mentioned this pull request Oct 25, 2021
Open
@mszylkowski mszylkowski mentioned this pull request Oct 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmajoulet gmajoulet gmajoulet approved these changes

Assignees

@mszylkowski mszylkowski

Labels

PR use: In LTS PR use: In Stable

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Story] storyContentLoaded event doesn't fire when loading story on page index != 0 [Story] Send storyContentLoaded event during prerendering

3 participants

@mszylkowski @gmajoulet @ampprojectbot