🖍 [Story audio] Move audio equalizer from video to story system layer#36264
Closed
mszylkowski wants to merge 9 commits intoampproject:mainfrom
Closed
🖍 [Story audio] Move audio equalizer from video to story system layer#36264mszylkowski wants to merge 9 commits intoampproject:mainfrom
mszylkowski wants to merge 9 commits intoampproject:mainfrom
Conversation
|
Hey @gmajoulet, @newmuis! These files were changed: |
Contributor
Author
|
We plan to remove the audio equalizer altogether so this PR can be closed. Will reopen if we need to reconsider this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the audio equalizer is attached to the videos, which makes it very inconsistent for the format:
By moving the eq to the story system layer, we ensure there will always be an eq on the page (and only one), properly positioned on the bottom right of the page.
Necessary steps:
noaudioon videos inampconf.htmlto have a story that shows and hides the equalizer accurately.Note: Works on RTL but the bars on the eq are not evenly distributed (happens also on

main). This PR doesn't change the looks of the equalizer, so I'll leave this bug fix for when the new UI is designed.