🖍 [Story performance] Remove standalone classes#36127
Merged
mszylkowski merged 18 commits intoampproject:mainfrom Oct 8, 2021
Merged
🖍 [Story performance] Remove standalone classes#36127mszylkowski merged 18 commits intoampproject:mainfrom
mszylkowski merged 18 commits intoampproject:mainfrom
Conversation
|
Hey @gmajoulet, @newmuis! These files were changed: |
Contributor
|
FYI the changes in this PR will drop specificity, which could cause breaking changes |
Contributor
Author
|
Good point. The only thing that changes specificity for stories are the not The other properties changing specificity is not breaking anything, since they are all |
gmajoulet
approved these changes
Sep 21, 2021
…l into remove_runtimeclasses
gmajoulet
approved these changes
Sep 30, 2021
gmajoulet
approved these changes
Oct 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
i-amphtml-story-standaloneselectors with:root.Closes #36049