Skip to content

✨ [Amp story] Activate desktop one panel experiment to 1.#35453

Merged
processprocess merged 4 commits intoampproject:mainfrom
processprocess:activate-one-panel
Aug 10, 2021
Merged

✨ [Amp story] Activate desktop one panel experiment to 1.#35453
processprocess merged 4 commits intoampproject:mainfrom
processprocess:activate-one-panel

Conversation

@processprocess
Copy link
Copy Markdown
Contributor

Activates amp-story-desktop-one-panel to 1.

@processprocess processprocess requested a review from gmajoulet July 29, 2021 12:38
@amp-owners-bot amp-owners-bot bot requested a review from jridgewell July 29, 2021 12:38
Copy link
Copy Markdown
Contributor

@gmajoulet gmajoulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update client-side-experiments-config.json too? That's the one to use if you want the experiment to be instantly flipped

@gmajoulet
Copy link
Copy Markdown
Contributor

cc @danielrozenberg FYI :))

@danielrozenberg
Copy link
Copy Markdown
Member

Do you want to immediately set it to 1 in prod/canary config, or gradually ramp it up through the client side experiments?

@processprocess processprocess requested a review from gmajoulet July 29, 2021 18:58
@processprocess
Copy link
Copy Markdown
Contributor Author

Do you want to immediately set it to 1 in prod/canary config, or gradually ramp it up through the client side experiments?

We don't have metrics to observe before deciding to launch, so we're thinking to push it all the way to 1.

Copy link
Copy Markdown
Contributor

@gmajoulet gmajoulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM, but let's get formal wg-stories PM/UX approval before merging

Copy link
Copy Markdown
Member

@danielrozenberg danielrozenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval for client-side-experiments-config.json

Copy link
Copy Markdown
Contributor

@gmajoulet gmajoulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Send it!! 🚢

@processprocess processprocess merged commit 7dc536f into ampproject:main Aug 10, 2021
@processprocess processprocess deleted the activate-one-panel branch August 10, 2021 18:21
@processprocess processprocess restored the activate-one-panel branch August 10, 2021 18:21
@ampprojectbot
Copy link
Copy Markdown
Member

This PR has been picked up by the CDN and will begin deploying shortly

@ampprojectbot
Copy link
Copy Markdown
Member

This experiment is now live and being served by the CDN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants