[amp-lightbox:1.0] Bento tracking issue #31052
Description
High-level requirements
| Consideration | Ready when | Status |
|---|---|---|
| Component compatibility | Conformance with 0.1 (see below) | ✅ |
| Testing | Unit tests and e2e tests from 0.1 | ✅ |
| Internationalization | n/a | n/a |
| Analytics | n/a | n/a |
| Accessibility | Audit performed, 0.1 for reference | ✅ |
| Page experience | Audit performed | ✅ |
| Documentation | Written | ✅ |
| Storybook | Samples written | ✅ |
Component compatibility
Attributes to support:
-
animate-in->animation(optional) -
data-close-button-aria-label(optional) -
scrollable(optional)
Migration Notes:
- This component does not currently support modifying browser history state.
data-close-button-aria-labelis not supported and will soon be replaced with support forslot="close-button".animate-inhas been renamed toanimation
Open tasks:
- Unit tests
- Address
scrollableprop (is it still necessary? not added for now) - Send out events upon open/close or let users pass in a function
- Modify history state (conformance to 0.1) - AMP only
- Support
slot="close-button"oncepassthroughandchildrenmodes are refactored - Add validations to include no-longer-supported attributes for backwards compatibility
- Cancellable backdrop