-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Closed
Labels
Description
summary
<amp-ad> accepts an optional json attribute. Some websites provide a string in that attribute which is technically valid json (as would be a number). This becomes a problem when attempting to assign to a property of jsonTargeting. It fails silently in sloppy mode, but will throw in both esm and strict mode.
amphtml/extensions/amp-ad-network-doubleclick-impl/0.1/amp-ad-network-doubleclick-impl.js
Line 907 in 4d5e5d3
| this.jsonTargeting['targeting'] = !!this.jsonTargeting['targeting'] |
@keithwrightbos: Do you know what the behavior should be in the case of a string json value? (or any non truthy non-object for that matter).
Reactions are currently unavailable