-
Notifications
You must be signed in to change notification settings - Fork 4.1k
🌸 Cherry-pick request for #25295 into #25319 #25417
Copy link
Copy link
Closed
Labels
Cherry-pick: BetaCherry-pick: ExperimentalCherry-pick: StableType: ReleaseUsed to track AMP releases from canary to productionUsed to track AMP releases from canary to production
Description
Cherry-pick request
| Issue | PR | Production? | RC? | Release issue |
|---|---|---|---|---|
| #13659 | #25295 | Yes | Yes | #25319 |
Why does this issue meet the cherry-pick criteria?
While this is a long standing issue with amp-live-list, this is an issue that more and more publishers are facing with amp-live-list always returning stale values. This is an opt in fix needed for Nov 5 elections. A long term cache side fix is being explored.
Why is a RC cherry-pick not needed?
Needs to be in RC and prod.
Mini-postmortem
TODO: This postmortem will be written after the cherry-pick deployment and before this issue is closed. Delete this TODO when the postmortem is ready.
Summary
<YOUR_SUMMARY>
| Users affected | Impact |
|---|---|
| Anyone who access amp-live-list from cache will be affected. | Loss of amp-live-list functionality on cache if updates are coming in very quickly. Origin is fine. |
Root Causes
Action Items
| Action Item | Type | Owner | PR # |
|---|---|---|---|
| <E.g. Add integration test> | <Investigate/Mitigate/Prevent> | @<USERNAME> | #<PR_NUMBER> |
Lessons Learned
Things that went well
Things that went wrong
/cc @ampproject/wg-approvers @ampproject/cherry-pick-approvers
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Cherry-pick: BetaCherry-pick: ExperimentalCherry-pick: StableType: ReleaseUsed to track AMP releases from canary to productionUsed to track AMP releases from canary to production