At long last, I experimented with using prettier for AMP. Since we use eslint for code formatting and for preventing known anti-patterns through custom rules in build-system/eslint-rules, my approach was to use eslint-plugin-prettier as part of our global .eslintrc, thereby switching to prettier for code formatting while continuing to use eslint for other checks.

Unfortunately, it looks like I've hit a blocking issue. AMP code requires quoted object keys to prevent aggressive minification by closure compiler (#10094), which resulted in the amphtml-internal/dict-string-keys rule. It doesn't look like there's a way to prevent prettier from stripping away these keys (prettier/prettier#4327), and it's unlikely that this bug will get fixed in the near future. The only workaround seems to be to use square brackets around keys to prevent them from being optimized away, and that doesn't seem like an acceptable solution.

@kristoferbaxter @cramforce Since you're more familiar with prettier than I am, are you aware of any other workarounds to this? Or are we at an impasse?

Full list of errors as of today: https://travis-ci.org/ampproject/amphtml/jobs/500592963#L1933

Adopt prettier for code formatting #17086

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Adopt `prettier` for code formatting #17086