Flaky tests: changeSize and discoverWork in test-resources.js #16124
Description
Per build: https://travis-ci.org/ampproject/amphtml/jobs/393815752
These are failing / flaky on Safari.
Error messages below:
DESCRIBE => Resources changeSize
DESCRIBE => attemptChangeSize rules wrt viewport
IT => should change size when document is invisible
✗ Attempted to wrap getVisibilityState which is already wrapped
checkWrappedMethod@/tmp/node_modules/sinon/lib/sinon/util/core/wrap-method.js:39 <- /tmp/76e9ec9ec8ad21bbdd44820c0bbaddcd.browserify:50286:34
wrapMethod@/tmp/node_modules/sinon/lib/sinon/util/core/wrap-method.js:85 <- /tmp/76e9ec9ec8ad21bbdd44820c0bbaddcd.browserify:50332:31
stub@/tmp/node_modules/sinon/lib/sinon/collection.js:119 <- /tmp/76e9ec9ec8ad21bbdd44820c0bbaddcd.browserify:47592:38
/tmp/test/functional/test-resources.js:1997:19 <- /tmp/76e9ec9ec8ad21bbdd44820c0bbaddcd.browserify:148925:19
--------------
wrapMethod@/tmp/node_modules/sinon/lib/sinon/util/core/wrap-method.js:110 <- /tmp/76e9ec9ec8ad21bbdd44820c0bbaddcd.browserify:50357:40
stub@/tmp/node_modules/sinon/lib/sinon/collection.js:119 <- /tmp/76e9ec9ec8ad21bbdd44820c0bbaddcd.browserify:47592:38
/tmp/test/functional/test-resources.js:1450:17 <- /tmp/76e9ec9ec8ad21bbdd44820c0bbaddcd.browserify:148335:17
●
IT => "after each" hook for "should change size when document is invisible"
✗ Expected getRect([...]) at least once (never called)
fail@/tmp/node_modules/sinon/lib/sinon/mock-expectation.js:281 <- /tmp/76e9ec9ec8ad21bbdd44820c0bbaddcd.browserify:48572:34
verify@/tmp/node_modules/sinon/lib/sinon/mock.js:108 <- /tmp/76e9ec9ec8ad21bbdd44820c0bbaddcd.browserify:48689:33
/tmp/test/functional/test-resources.js:1785:4 <- /tmp/76e9ec9ec8ad21bbdd44820c0bbaddcd.browserify:148717:24
●
IT => "after each" hook for "should change size when document is invisible"
✗ You likely forgot to restore sinon timers (installed via sandbox.useFakeTimers).
/tmp/test/_init_tests.js:479:20 <- /tmp/76e9ec9ec8ad21bbdd44820c0bbaddcd.browserify:111859:20
[20:57:18] Safari 11.1.0 (Mac OS X 10.13.4): Executed 1760 of 3610 (Skipped 174) 4 FAILED
Also from the same test suite, these are flaky / failing on Windows Chrome.
DESCRIBE => Resources discoverWork
IT => "after each" hook for "should render two screens when visible"
✗ Unexpected call: getRect() at setState@/tmp/src/finite-state-machine.js:73:6 <- /tmp/a3788620192f2b19616a0bb87a169728.browserify:66567:15
Unexpected call: getRect() at setState@/tmp/src/finite-state-machine.js:73:6 <- /tmp/a3788620192f2b19616a0bb87a169728.browserify:66567:15
Expectation met: getRect([...]) once
fail@/tmp/node_modules/sinon/lib/sinon/mock-expectation.js:281 <- /tmp/a3788620192f2b19616a0bb87a169728.browserify:48590:34
verify@/tmp/node_modules/sinon/lib/sinon/mock.js:108 <- /tmp/a3788620192f2b19616a0bb87a169728.browserify:48707:33
/tmp/test/functional/test-resources.js:1116:4 <- /tmp/a3788620192f2b19616a0bb87a169728.browserify:148053:24