Skip to content

Mocha silently skips tests when an async error is thrown #15658

New issue
New issue
Closed
#17213
#16916
Closed
Mocha silently skips tests when an async error is thrown#15658
#17213
#16916
Assignees
rsimha
Labels
BlockedP2: SoonStaleInactive for one year or moreWG: infra
Milestone
Pending Triage
@rsimha

Description

@rsimha
rsimha
opened on May 30, 2018

@jpettitt reported this while running the following test:

amphtml/extensions/amp-user-notification/0.1/test/test-amp-user-notification.js

Lines 80 to 88 in 97847f2

it('should require an id', () => {
const el = getUserNotification({
'data-show-if-href': 'https://www.ampproject.org/get/here',
'data-dismiss-href': 'https://www.ampproject.org/post/here',
'layout': 'nodisplay',
});
const impl = el.implementation_;
expect(impl.buildCallback.bind(impl)).to.throw(/should have an id/);
});

The error at the end of the test gets thrown asynchronously, by which time the test has completed. So Mocha makes it look like the test has passed, but the thrown error prevents it from running subsequent tests.

See mochajs/mocha#3223 and mochajs/mocha#3257 for more info on why this is a mocha problem.

Metadata

Metadata

Assignees

Labels

BlockedP2: SoonStaleInactive for one year or moreWG: infra

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions