Skip to content

amp-carousel causing document height to fluctuate / be too large #11929

@brandondiamond

Description

@brandondiamond

What's the issue?

We are attempting to measure the document height and scroll position to compute a scroll depth percentage. At the moment, we're using the maximum height of the document over the course of a session.

Unfortunately, it seems that for many documents containing an amp-carousel component, the height can be very large. It can also be somewhat varied.

To mitigate, we could avoid using the maximum height and instead use the last height. But as the height appears to "stabilize" over time, short sessions might still be associated with an invalid, large height.

We chatted with Justin about some possible resolutions and he had a few interesting proposals. I'll let Justin jump in with some extra context.

How do we reproduce the issue?

Please contact bdiamond@ for more details about this issue.

What browsers are affected?

All browsers

Which AMP version is affected?

All versions

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions