Skip to content

Commit 679e684

Browse files
powdercloudGregable
authored andcommitted
Add the amp-embed tag.
See #1607 I copied over from amp-ad, then edited name and comment. Also placed a hint that they should be changed together.
1 parent e274687 commit 679e684

1 file changed

Lines changed: 22 additions & 1 deletion

File tree

validator/validator.protoascii

Lines changed: 22 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ min_validator_revision_required: 81
2525
# newer versions of the spec file. This is currently a Google internal
2626
# mechanism, validator.js does not use this facility. However, any
2727
# change to this file requires updating this revision id.
28-
spec_file_revision: 128
28+
spec_file_revision: 129
2929
# Rules for AMP HTML
3030
# (https://github.com/google/amphtml/blob/master/spec/amp-html-format.md).
3131
# These rules are just enough to validate the example from the spec.
@@ -2272,6 +2272,8 @@ tags: {
22722272
}
22732273
}
22742274
# <amp-ad>
2275+
# In the AMP Runtime, amp-ad and amp-embed are implemented in the same way,
2276+
# so if you're changing amp-ad consider changing amp-embed as well.
22752277
tags: {
22762278
name: "amp-ad"
22772279
spec_url: "https://github.com/ampproject/amphtml/blob/master/builtins/amp-ad.md"
@@ -2288,6 +2290,25 @@ tags: {
22882290
supported_layouts: NODISPLAY
22892291
}
22902292
}
2293+
# <amp-embed>
2294+
# In the AMP Runtime, amp-ad and amp-embed are implemented in the same way,
2295+
# so if you're changing amp-embed consider changing amp-ad as well.
2296+
tags: {
2297+
name: "amp-embed"
2298+
spec_url: "https://github.com/ampproject/amphtml/blob/master/builtins/amp-embed.md"
2299+
attr_lists: "extended-amp-global"
2300+
attrs: { name: "alt" }
2301+
attrs: { name: "src" }
2302+
attrs: { name: "type" mandatory: true }
2303+
attrs: { name: "json" }
2304+
amp_layout: {
2305+
supported_layouts: FIXED
2306+
supported_layouts: FIXED_HEIGHT
2307+
supported_layouts: RESPONSIVE
2308+
supported_layouts: FILL
2309+
supported_layouts: NODISPLAY
2310+
}
2311+
}
22912312
# <amp-facebook>
22922313
tags: {
22932314
name: "amp-facebook"

0 commit comments

Comments
 (0)