Make Array includes() polyfill not enumerable (#7517)

aghassemi · web-flow · commit 05d0f577fdc2 · 2017-02-13T17:00:21.000-08:00
diff --git a/src/polyfills/array-includes.js b/src/polyfills/array-includes.js
@@ -44,6 +44,11 @@ function includes(value, opt_fromIndex) {
 */
 export function install(win) {
   if (!win.Array.prototype.includes) {
-    win.Array.prototype.includes = includes;
+    win.Object.defineProperty(Array.prototype, 'includes', {
+      enumerable: false,
+      configurable: true,
+      writable: true,
+      value: includes,
+    });
   }
 }
diff --git a/src/polyfills/document-contains.js b/src/polyfills/document-contains.js
@@ -37,6 +37,11 @@ function documentContainsPolyfill(node) {
  */
 export function install(win) {
   if (!win.HTMLDocument.prototype.contains) {
-    win.HTMLDocument.prototype.contains = documentContainsPolyfill;
+    win.Object.defineProperty(win.HTMLDocument.prototype, 'contains', {
+      enumerable: false,
+      configurable: true,
+      writable: true,
+      value: documentContainsPolyfill,
+    });
   }
 }
diff --git a/src/polyfills/domtokenlist-toggle.js b/src/polyfills/domtokenlist-toggle.js
@@ -42,7 +42,12 @@ function domTokenListTogglePolyfill(token, opt_force) {
  */
 export function install(win) {
   if (isIe(win) && win.DOMTokenList) {
-    win.DOMTokenList.prototype.toggle = domTokenListTogglePolyfill;
+    win.Object.defineProperty(win.DOMTokenList.prototype, 'toggle', {
+      enumerable: false,
+      configurable: true,
+      writable: true,
+      value: domTokenListTogglePolyfill,
+    });
   }
 }
 
diff --git a/src/polyfills/math-sign.js b/src/polyfills/math-sign.js
@@ -40,6 +40,11 @@ export function sign(x) {
  */
 export function install(win) {
   if (!win.Math.sign) {
-    win.Math.sign = sign;
+    win.Object.defineProperty(win.Math, 'sign', {
+      enumerable: false,
+      configurable: true,
+      writable: true,
+      value: sign,
+    });
   }
 }
diff --git a/src/polyfills/object-assign.js b/src/polyfills/object-assign.js
@@ -50,6 +50,11 @@ export function assign(target, var_args) {
  */
 export function install(win) {
   if (!win.Object.assign) {
-    win.Object.assign = assign;
+    win.Object.defineProperty(win.Object, 'assign', {
+      enumerable: false,
+      configurable: true,
+      writable: true,
+      value: assign,
+    });
   }
 }
diff --git a/test/functional/test-polyfill-document-contains.js b/test/functional/test-polyfill-document-contains.js
@@ -37,12 +37,14 @@ describe('HTMLDocument.contains', () => {
       HTMLDocument: class {
         contains() {}
       },
+      Object: window.Object,
     };
     nativeContains = fakeWinWithContains.HTMLDocument.prototype.contains;
 
     fakeWinWithoutContains = {
       HTMLDocument: class {
       },
+      Object: window.Object,
     };
     install(fakeWinWithoutContains);
     polyfillContains = fakeWinWithoutContains.HTMLDocument.prototype.contains;

Original file line number	Diff line number	Diff line change
`@@ -44,6 +44,11 @@ function includes(value, opt_fromIndex) {`
`44`	`44`	`*/`
`45`	`45`	`export function install(win) {`
`46`	`46`	`if (!win.Array.prototype.includes) {`
`47`		`- win.Array.prototype.includes = includes;`
	`47`	`+ win.Object.defineProperty(Array.prototype, 'includes', {`
	`48`	`+ enumerable: false,`
	`49`	`+ configurable: true,`
	`50`	`+ writable: true,`
	`51`	`+ value: includes,`
	`52`	`+ });`
`48`	`53`	`}`
`49`	`54`	`}`
Original file line number	Diff line number	Diff line change
`@@ -37,6 +37,11 @@ function documentContainsPolyfill(node) {`
`37`	`37`	`*/`
`38`	`38`	`export function install(win) {`
`39`	`39`	`if (!win.HTMLDocument.prototype.contains) {`
`40`		`- win.HTMLDocument.prototype.contains = documentContainsPolyfill;`
	`40`	`+ win.Object.defineProperty(win.HTMLDocument.prototype, 'contains', {`
	`41`	`+ enumerable: false,`
	`42`	`+ configurable: true,`
	`43`	`+ writable: true,`
	`44`	`+ value: documentContainsPolyfill,`
	`45`	`+ });`
`41`	`46`	`}`
`42`	`47`	`}`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,12 @@ function domTokenListTogglePolyfill(token, opt_force) {`
`42`	`42`	`*/`
`43`	`43`	`export function install(win) {`
`44`	`44`	`if (isIe(win) && win.DOMTokenList) {`
`45`		`- win.DOMTokenList.prototype.toggle = domTokenListTogglePolyfill;`
	`45`	`+ win.Object.defineProperty(win.DOMTokenList.prototype, 'toggle', {`
	`46`	`+ enumerable: false,`
	`47`	`+ configurable: true,`
	`48`	`+ writable: true,`
	`49`	`+ value: domTokenListTogglePolyfill,`
	`50`	`+ });`
`46`	`51`	`}`
`47`	`52`	`}`
`48`	`53`
Original file line number	Diff line number	Diff line change
`@@ -40,6 +40,11 @@ export function sign(x) {`
`40`	`40`	`*/`
`41`	`41`	`export function install(win) {`
`42`	`42`	`if (!win.Math.sign) {`
`43`		`- win.Math.sign = sign;`
	`43`	`+ win.Object.defineProperty(win.Math, 'sign', {`
	`44`	`+ enumerable: false,`
	`45`	`+ configurable: true,`
	`46`	`+ writable: true,`
	`47`	`+ value: sign,`
	`48`	`+ });`
`44`	`49`	`}`
`45`	`50`	`}`
Original file line number	Diff line number	Diff line change
`@@ -50,6 +50,11 @@ export function assign(target, var_args) {`
`50`	`50`	`*/`
`51`	`51`	`export function install(win) {`
`52`	`52`	`if (!win.Object.assign) {`
`53`		`- win.Object.assign = assign;`
	`53`	`+ win.Object.defineProperty(win.Object, 'assign', {`
	`54`	`+ enumerable: false,`
	`55`	`+ configurable: true,`
	`56`	`+ writable: true,`
	`57`	`+ value: assign,`
	`58`	`+ });`
`54`	`59`	`}`
`55`	`60`	`}`