Conversation
|
@westonruter do you need anything else for the blog integration? |
There was a problem hiding this comment.
Looks good to me! @westonruter, in case you're missing context: this will extend https://amp.dev/shared/header/ to also return the search markup.
|
OK, so right now the blog is doing: #searchTriggerOpen,
.ap-o-burger-menu-label {
display: none;
}This styling could be removed with this deployed? |
|
@westonruter Is there a way to test this before deploying? |
|
Is there a dev URL for this change that we can point the blog to? |
|
@sebastianbenz OK, so apparently this was deployed? So this can be tested now… and it breaks: The issue appears to be that the fragment being pulled in is using optimized AMP, which the AMP plugin does not allow as input, causing them to be stripped out by the sanitizer: It's currently not broken on https://blog.amp.dev, but it is broken on a https://test-amphtml-blog.pantheonsite.io/ presumably because the cached header.html hasn't expired yet, but within a week it will be broken once the transient expires. I'll preemptively add |
|
For some reason the |
|
The reason for the AMP validation error is that the validator is not properly accounting for |
|
For a quick fix, I've just stripped out the |
|
@sebastianbenz What CSS specifically does this new search component require? It seems like |
|
@sebil, can you confirm adding |
|
@matthiasrohmer there is also |



See #2924