Reorganize the structure of block-validation directory#6022
Merged
westonruter merged 3 commits intodevelopfrom Mar 30, 2021
Merged
Reorganize the structure of block-validation directory#6022westonruter merged 3 commits intodevelopfrom
block-validation directory#6022westonruter merged 3 commits intodevelopfrom
Conversation
The two entry points: `block-validation` and `block-editor` are both used in the context of the block editor. Potentially they could share the same entry point so that code re-usability would be better. This is the first step of the process. The directory structure of the `block-validation` is now more organized and should match the structure of the `block-editor` folder. This change will also allow us to cleanly migrate the `amp-toggle` plugin from `block-editor` to `block-validation`. With #5997, this plugin logically belongs to `block-validation` since it renders AMP status notification that in turn is based on the AMP validation status.
pierlon
reviewed
Mar 26, 2021
Contributor
pierlon
left a comment
There was a problem hiding this comment.
Great work! Components and the plugin for block-validation are now organized in a structured and easy to follow manner.
Co-authored-by: Pierre Gordon <16200219+pierlon@users.noreply.github.com>
Collaborator
Author
|
Thanks for the review, @pierlon! |
Contributor
|
Plugin builds for ba1301a are ready 🛎️!
|
pierlon
approved these changes
Mar 26, 2021
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The two entry points:
block-validationandblock-editorare both used in the context of the block editor. Potentially they could share the same entry point so that code re-usability would be better.This is the first step of the process. With this PR the directory structure of the
block-validationis more organized and matches the structure of theblock-editorfolder.This change will also allow us to cleanly migrate the
amp-toggleplugin fromblock-editortoblock-validation. With #5997, the plugin would logically belong better toblock-validationsince it renders AMP status notification that in turn is based on the AMP validation results.Relates to #5997
Checklist