Skip to content

Allow boolean attributes to repeat repeat attribute name as attribute value#5157

Merged
westonruter merged 2 commits intodevelopfrom
fix/boolean-attribute-handling
Aug 3, 2020
Merged

Allow boolean attributes to repeat repeat attribute name as attribute value#5157
westonruter merged 2 commits intodevelopfrom
fix/boolean-attribute-handling

Conversation

@westonruter
Copy link
Copy Markdown
Member

Summary

Fixes #5156.

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@westonruter westonruter added this to the v2.0 milestone Aug 3, 2020
@westonruter westonruter requested a review from schlessera August 3, 2020 19:34
@google-cla google-cla bot added the cla: yes Signed the Google CLA label Aug 3, 2020
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 3, 2020

Plugin builds for f9e5654 are ready 🛎️!

@westonruter westonruter requested a review from pierlon August 3, 2020 20:09
@westonruter westonruter merged commit b15b507 into develop Aug 3, 2020
@westonruter westonruter deleted the fix/boolean-attribute-handling branch August 3, 2020 20:49
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changelogged Whether the issue/PR has been added to release notes. cla: yes Signed the Google CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Boolean attributes erroneously flagged as validation errors when name copied as value

2 participants