Remove requirement for analytics to entries to have type supplied#4802
Closed
westonruter wants to merge 6 commits intodevelopfrom
Closed
Remove requirement for analytics to entries to have type supplied#4802westonruter wants to merge 6 commits intodevelopfrom
westonruter wants to merge 6 commits intodevelopfrom
Conversation
9908861 to
7198677
Compare
Contributor
|
Plugin builds for ba895cc are ready 🛎️!
|
Member
Author
|
Rather than being satisfied with this as-is, in 1.6+ I'd rather see this Analytics screen removed entirely and moved into an “Advanced” area of the main settings screen. This section would be collapsed by default. We'd use the REST API to update the Analytics and get rid of the current codebase entirely. See #2317. |
3 tasks
Contributor
|
Removing this from the v2.1 milestone since it's already been fixed in #5155. |
Member
Author
|
|
Member
Author
|
Oh, woops. This PR was not merged. It is obsolete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This addresses an issue raised in support topic where in-house analytics (which are supposed to lack a
typeattribute) arerequiredattribute from Type input field and server-side validation.typefromamp-analyticstag when Type is empty.Checklist