Enforce UTF-8 content-type header#4296
Merged
westonruter merged 2 commits intodevelopfrom Feb 17, 2020
Merged
Conversation
Member
|
I confirmed this worked by forcing a site to be created in latin1 and then creating a post with the table in https://cs.stanford.edu/people/miles/iso8859.html The Latin1 characters rendered as expected in AMP both in Transitional and Reader modes, with the page itself being actually UTF-8 because of the AMP plugin. |
westonruter
approved these changes
Feb 16, 2020
Member
westonruter
left a comment
There was a problem hiding this comment.
@kienstra please double-check this using your testing instructions as well.
Contributor
|
Looks Good! Hi @schlessera, Testing this PR with these instructions, they look the same: Non-AMP
AMP
|
kienstra
approved these changes
Feb 17, 2020
Collaborator
Author
|
Phew! The endless fiddling with DOMDocument bugs and encoding weirdnesses was successful after all! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We're already convert the encoding from non-UTF-8 to UTF-8 within the DOMDocument extension, but WordPress still outputs a content-type header with the old charset.
This PR fixes this, and also removes a
trigger_errorthat is not needed anymore.Fixes #855
Checklist