Skip to content

Improve compatibility of legacy stories editor with Gutenberg plugin#4074

Closed
swissspidy wants to merge 1 commit intodevelopfrom
fix/legacy-stories-gb-compat
Closed

Improve compatibility of legacy stories editor with Gutenberg plugin#4074
swissspidy wants to merge 1 commit intodevelopfrom
fix/legacy-stories-gb-compat

Conversation

@swissspidy
Copy link
Copy Markdown
Collaborator

@swissspidy swissspidy commented Jan 13, 2020

Summary

Addresses https://wordpress.org/support/topic/new-version-of-gutenberg-breaks-stories-layout/

  • Updates obsolete class names in CSS
  • Fixes selectors used for DOM manipulation
  • Replace usage of deprecated IconButton with Button
  • Hides some newly added elements from the UI

This way it works better with the Gutenberg plugin active, but doesn't fully work with WordPress 5.3 at the moment. Don't think it's worth trying to make it work for both.

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@googlebot googlebot added the cla: yes Signed the Google CLA label Jan 13, 2020
@westonruter westonruter added this to the v1.4.3 milestone Jan 13, 2020
@westonruter
Copy link
Copy Markdown
Member

westonruter commented Jan 13, 2020 •
edited
Loading

Milestoning for 1.4.3 assuming we can cherry-pick onto the 1.4 branch.

@westonruter
Copy link
Copy Markdown
Member

westonruter commented Jan 30, 2020

@swissspidy Do I understand correctly that this PR is not going forward? If so, is another PR needed which disables the AMP Stories experience if either the user is on WordPress version under 5.3 or they have a Gutenberg version that is too new?

In addition to these, we need to hide the Stories experience entirely (the experience checkboxes) if the user has no amp_story posts created. The thinking being that we can continue to allow access to Stories for users who are using them, but we discontinue offering the Stories feature for new installs or people who don't have stories created. In the place of the experience checkboxes, perhaps there should be a link to the Web Stories repo to get a peek of what's coming?

@swissspidy
Copy link
Copy Markdown
Collaborator Author

swissspidy commented Jan 30, 2020

Yeah that seems accurate for now.

We should write down all these things in #4172 and then create multiple PRs for the individual parts.

@swissspidy swissspidy closed this Jan 30, 2020
This was referenced Jan 30, 2020
Closed
Closed
Closed
@westonruter westonruter removed this from the v1.4.3 milestone Feb 9, 2020
@schlessera schlessera deleted the fix/legacy-stories-gb-compat branch November 6, 2020 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes Signed the Google CLA

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@swissspidy @westonruter @googlebot