Skip to content

Fix enqueueing of paired browsing JS on WP 4.9#3963

Merged
westonruter merged 2 commits intodevelopfrom
fix/3932-paired-browsing-wp-4.9
Dec 19, 2019
Merged

Fix enqueueing of paired browsing JS on WP 4.9#3963
westonruter merged 2 commits intodevelopfrom
fix/3932-paired-browsing-wp-4.9

Conversation

@pierlon
Copy link
Copy Markdown
Contributor

@pierlon pierlon commented Dec 18, 2019

Summary

This PR adds the wp-polyfill & wp-url JS polyfills so that the paired browsing JS files can be loaded on WP 4.9.

The paired browsing app was not being loaded due to the dependencies wp-polyfill & wp-urlbeing missing, and the client was missing the wp-polyfill dependency.

Fixes #3932

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@googlebot googlebot added the cla: yes Signed the Google CLA label Dec 18, 2019
@pierlon pierlon requested a review from westonruter December 18, 2019 20:25
@pierlon pierlon changed the title Fix/3932 paired browsing wp 4.9 Fix enqueueing of paired browsing JS on WP 4.9 Dec 18, 2019
@westonruter westonruter added this to the v1.5 milestone Dec 19, 2019
@westonruter
Copy link
Copy Markdown
Member

@pierlon Would you please rebase from develop and resolve the conflicts?

@pierlon
Copy link
Copy Markdown
Contributor Author

pierlon commented Dec 19, 2019

⚠️ Rebasing with latest changes from develop.

@pierlon pierlon force-pushed the fix/3932-paired-browsing-wp-4.9 branch from 0356446 to c90c37c Compare December 19, 2019 22:06
@westonruter westonruter merged commit b406b5e into develop Dec 19, 2019
@westonruter westonruter deleted the fix/3932-paired-browsing-wp-4.9 branch December 19, 2019 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Signed the Google CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Paired browsing JS fails to load in WordPress 4.9

4 participants